fix: removeNoise function not working correctly #557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am currently developing some cerebro plugins and have noticed that the current function that removes words from plugin names is not working correctly. This is the case of
cerebro-todoist, whose name is modified appearing only "Doist". I've slightly modified the regex for each usage (name and description) so there should no longer be a problem with names like "cerebro-toggle-..." appearing as "ggle".The new regex removes words like 'cerebro-' and 'cerebro-plugin-' from the plugins name but not affecting to the rest of the name.
Before
After
