Fix serif font on systems that do not define a system font #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some linux distributions that do not use a desktop environment do not define a system font. On these systems, the system-font css file does not work if none of the font families are matched (and it seems chrome ignores it anyway). I added sans-serif as a fallback font, which is usually always defined in fontconfig as a sans-serif font. Without this, cerebro uses an ugly ans obscure serif font due to no fallback having been found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some linux distributions that do not use a desktop environment do
not define a system font. On these systems, the system-font css file
does not work if none of the font families are matched (and it
seems chrome ignores it anyway).
I added sans-serif as a fallback font, which is usually always defined
in fontconfig as a sans-serif font.
Without this, cerebro uses an ugly ans obscure serif font due to
no fallback having been found.