Skip to content
This repository has been archived by the owner on Feb 17, 2019. It is now read-only.

Integrate fullPage.js #92

Merged
merged 13 commits into from
Dec 29, 2018
Merged

Integrate fullPage.js #92

merged 13 commits into from
Dec 29, 2018

Conversation

rossoskull
Copy link
Member

@rossoskull rossoskull commented Dec 15, 2018

Fixes #81
Currently, the Panel component's style isn't updated to suit the fullpage.

Preview
ezgif-4-bafde4f9b2cb

@netlify
Copy link

netlify bot commented Dec 15, 2018

PR preview deployed at -

Built with commit 41e0a15

https://app.netlify.com/sites/cerebro-web/deploys/5c2763cb354c4b0008f2e31f

Copy link
Contributor

@DivyeshPuri DivyeshPuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rossoskull It is not working correctly in mobile view. Please do check.

Copy link
Member

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rossoskull Thanks for PR

Please address these:

  • You might need to update your branch as per current master branch.
  • Card sizes are changes for some reason.
  • Also, you might need to disable overflow-x in Mobile view.
  • Also, please add a permanent black background to fixed nav.
  • And yeah as @DivyeshPuri said footer is missing in desktop view.

Also, welcome to the org, accept the invite.

Copy link
Contributor

@DivyeshPuri DivyeshPuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Footer is also missing.

@rossoskull
Copy link
Member Author

@aashutoshrathi thanks.
Due to fullpage.js, footer is missing, as it is not added as a 'section'. But when we decrease the screen size, it is visible. So should I add the footer as a section to show it in full screen size?

Will do the required changes to the nav and overflow.

@aashutoshrathi
Copy link
Member

Cards still have less width. 😿

@rossoskull
Copy link
Member Author

@aashutoshrathi I have used uk's slider, as fullpage's slide wouldn't be a good option for small screens, styling is primitive, basics are implemented, and also threw in a nav bar.

@aashutoshrathi
Copy link
Member

Will check @rossoskull

Copy link
Contributor

@DivyeshPuri DivyeshPuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Auto slide missing
  2. Arrows missing in the carousel
  3. Fix card size in mobile view

@rossoskull
Copy link
Member Author

@DivyeshPuri Made the changes.

Copy link
Contributor

@DivyeshPuri DivyeshPuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rossoskull Awesome work buddy 🎉 . @aashutoshrathi @anshumanv Review it.

@anshumanv anshumanv merged commit 5b3cf97 into cerebro-iiitv:dev Dec 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants