-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
PR preview deployed at - Built with commit 41e0a15 https://app.netlify.com/sites/cerebro-web/deploys/5c2763cb354c4b0008f2e31f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rossoskull It is not working correctly in mobile view. Please do check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rossoskull Thanks for PR
Please address these:
- You might need to update your branch as per current master branch.
- Card sizes are changes for some reason.
- Also, you might need to disable overflow-x in Mobile view.
- Also, please add a permanent black background to fixed nav.
- And yeah as @DivyeshPuri said footer is missing in desktop view.
Also, welcome to the org, accept the invite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Footer is also missing.
@aashutoshrathi thanks. Will do the required changes to the nav and overflow. |
Cards still have less width. 😿 |
@aashutoshrathi I have used uk's slider, as fullpage's slide wouldn't be a good option for small screens, styling is primitive, basics are implemented, and also threw in a nav bar. |
Will check @rossoskull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Auto slide missing
- Arrows missing in the carousel
- Fix card size in mobile view
@DivyeshPuri Made the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rossoskull Awesome work buddy 🎉 . @aashutoshrathi @anshumanv Review it.
Fixes #81
Currently, the Panel component's style isn't updated to suit the fullpage.
Preview