Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: address deprecations #1436

Merged
merged 3 commits into from
Jan 22, 2024
Merged

chore: address deprecations #1436

merged 3 commits into from
Jan 22, 2024

Conversation

bf4
Copy link
Collaborator

@bf4 bf4 commented Jan 22, 2024

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@bf4
chore(deprecation): test_fixture= has been deprecated
e991cf6 
in favor of tests_fixtures=
@bf4
chore(deprecations): ActiveSupport::Deprecation.silenced
84b13b1 
```
ActiveSupport::Deprecation is deprecated and will be removed from Rails
(use Rails.application.deprecators.silenced= instead)
```
@bf4
chore(deprecation): prefer ActiveSupport.deprectator
2cf6114 
or our own deprecator.

since https://github.com/rails/rails/pull/47354/files
@lgebhardt lgebhardt merged commit 51c9592 into v0-11-dev Jan 22, 2024
39 checks passed
@lgebhardt lgebhardt deleted the address_deprecations branch January 22, 2024 20:15
@lgebhardt
Copy link
Member

Thanks!

lgebhardt pushed a commit that referenced this pull request Apr 18, 2024
@bf4 @lgebhardt
chore: address deprecations (#1436)
b0137ba 
* chore(deprecation): test_fixture= has been deprecated

in favor of tests_fixtures=

* chore(deprecations): ActiveSupport::Deprecation.silenced

```
ActiveSupport::Deprecation is deprecated and will be removed from Rails
(use Rails.application.deprecators.silenced= instead)
```

* chore(deprecation): prefer ActiveSupport.deprectator

or our own deprecator.

since https://github.com/rails/rails/pull/47354/files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgebhardt lgebhardt lgebhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bf4 @lgebhardt