Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more flexible polymorphic types lookup #1434

Merged
merged 8 commits into from
Jan 25, 2024
Merged

fix: more flexible polymorphic types lookup #1434

merged 8 commits into from
Jan 25, 2024

Commits on Jan 24, 2024

  1. fix: more flexible polymorphic types lookup

    @bf4
    bf4 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    e67d676 View commit details
    Browse the repository at this point in the history

  2. test: add polymorphic lookup tests 

    they pass on v-11-dev

I'm going to look into the existing lookup warnings

now
```
[POLYMORPHIC TYPE NOT FOUND] No polymorphic types found for fileable
[POLYMORPHIC TYPE] No polymorphic types found for FilePropertiesResource fileable
[POLYMORPHIC TYPE NOT FOUND] No polymorphic types found for respondent
[POLYMORPHIC TYPE] No polymorphic types found for QuestionResource respondent
[POLYMORPHIC TYPE NOT FOUND] No polymorphic types found for respondent
[POLYMORPHIC TYPE] No polymorphic types found for AnswerResource respondent
[POLYMORPHIC TYPE NOT FOUND] No polymorphic types found for keepable
[POLYMORPHIC TYPE] No polymorphic types found for KeeperResource keepable
```
    @bf4
    bf4 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    d14cbad View commit details
    Browse the repository at this point in the history

  3. Revert "test: add polymorphic lookup tests" 

    This reverts commit 0979a7243b6bc816dd2327d3ff23f70209c52dce.
    @bf4
    bf4 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    221244b View commit details
    Browse the repository at this point in the history

  4. feat: easily clear the lookup

    @bf4
    bf4 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    658f2bb View commit details
    Browse the repository at this point in the history

  5. feat: add a descendents strategy

    @bf4
    bf4 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    5bec2e0 View commit details
    Browse the repository at this point in the history

  6. test: polymorphic type lookup

    @bf4
    bf4 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    7946f83 View commit details
    Browse the repository at this point in the history

  7. feat: make polymorphic type lookup configurable

    @bf4
    bf4 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    ed41c8c View commit details
    Browse the repository at this point in the history

  8. feat: clear polymorphic lookup after initialize

    @bf4
    bf4 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    93ac314 View commit details
    Browse the repository at this point in the history