Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write directly to postgres #16

Merged
merged 7 commits into from
Dec 3, 2020
Merged

Write directly to postgres #16

merged 7 commits into from
Dec 3, 2020

Conversation

roysc
Copy link
Contributor

@roysc roysc commented Nov 16, 2020 •
edited
Loading

Resolves #15

To do:

@roysc roysc requested a review from i-norden November 16, 2020 09:59
@roysc roysc marked this pull request as draft November 16, 2020 09:59
@roysc roysc marked this pull request as ready for review November 16, 2020 10:28
@roysc
fix import
bd5d299 
add namespacing to avoid name conflicts
i-norden
i-norden approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@i-norden i-norden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only thing I'd add is some quick documentation on how to run in this mode.

@roysc roysc merged commit d3bed86 into master Dec 3, 2020
@roysc roysc deleted the direct-to-postgres branch December 3, 2020 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-norden i-norden i-norden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write directly to Postgres
2 participants
@roysc @i-norden