editorial pass #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 8, 2022 23:34
Signed-off-by: bumblefudge <[email protected]>
Signed-off-by: bumblefudge <[email protected]>
|
@zachferland i can't tag you for review but you should probably check nothign I rephrased got mangled, particularly this and this |
zachferland
reviewed
Dec 13, 2022
There was a problem hiding this comment.
thanks @bumblefudge, minor wording change to your edits, let me know if that makes sense
| 32 byte argument is the merkle-root CID. A CID is more than 32 bytes, and a | ||
| partial CID is used to allow the argument to be efficiently packed in the | ||
| transaction. Function name or contract does not matter, and is up to the | ||
| implementation. Use of a root CID encoded in [DAG-CBOR][] is recommended. |
Co-authored-by: Zach Ferland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bumblefudge [email protected]