use the configured owner rather than hard-coded 'ubuntu' value #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the user ubuntu
|
This makes sense when running teuthology locally, but a remote host may have a different unix user. Currently user@host is the format of the targets, which (iirc) ends up in each remote.name. Using this username instead of the 'owner' field would work on local and remote hosts. |
|
Yeah, let's take the user@ bit out of the remote name. |
|
I have a different version of this patch that I will submit. Closing this pull request as this code will not go in. |
kshtsk
pushed a commit
to kshtsk/teuthology
that referenced
this pull request
Nov 14, 2019
Rebase to ceph/master Reviewed-by: Loic Dachary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the user 'ubuntu' is currently hard-coded for worksets. This change uses the configured owner.