Skip to content

Commit

Permalink
s3select: add output definitions to parquet (#158)
Browse files Browse the repository at this point in the history
Signed-off-by: Albin Antony <[email protected]>
  • Loading branch information
albin-antony authored Jul 17, 2024
1 parent 2ca3b6c commit 2680e95
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions include/s3select.h
Original file line number Diff line number Diff line change
Expand Up @@ -3029,6 +3029,9 @@ class parquet_object : public base_s3object

public:

class csv_definitions : public s3select_csv_definitions
{};

parquet_object(std::string parquet_file_name, s3select *s3_query,s3selectEngine::rgw_s3select_api* rgw) : base_s3object(s3_query),object_reader(nullptr)
{
try{
Expand Down Expand Up @@ -3082,10 +3085,10 @@ class parquet_object : public base_s3object
return m_s3_select != nullptr;
}

void set_parquet_object(std::string parquet_file_name, s3select *s3_query,s3selectEngine::rgw_s3select_api* rgw) //TODO duplicate code
void set_parquet_object(std::string parquet_file_name, s3select *s3_query,s3selectEngine::rgw_s3select_api* rgw,csv_definitions parquet) //TODO duplicate code
{
try{

m_csv_defintion = parquet;
object_reader = new parquet_file_parser(parquet_file_name,rgw); //TODO uniq ptr
} catch(std::exception &e)
{
Expand Down

0 comments on commit 2680e95

Please sign in to comment.