Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobList: Fix a hang when sorting #76

Merged
merged 1 commit into from
Jun 19, 2024
Merged

JobList: Fix a hang when sorting #76

merged 1 commit into from
Jun 19, 2024

Conversation

zmc
Copy link
Member

@zmc zmc commented Jun 17, 2024

Somehow, the filter call was causing a render loop. Memoizing fixes that.

Somehow, the filter call was causing a render loop. Memoizing fixes that.

Signed-off-by: Zack Cerza <[email protected]>
Copy link

render bot commented Jun 17, 2024

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for pulpito ready!

Name Link
🔨 Latest commit c8cdceb
🔍 Latest deploy log https://app.netlify.com/sites/pulpito/deploys/6670ad732591410008fe684e
😎 Deploy Preview https://deploy-preview-76--pulpito.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@VallariAg VallariAg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me - thanks for explaining this PR on call!

@zmc zmc merged commit 2d10f49 into main Jun 19, 2024
7 checks passed
@zmc zmc deleted the jl-hang branch June 19, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants