Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libs3.spec: use 'make install-all' instead 'make install' to build rp… #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hjwsm1989
Copy link

…m package.

Signed-off-by: huangjun [email protected]

@ktdreyer
Copy link
Member

Would you please submit this change to libs3 upstream? https://github.com/bji/libs3

@hjwsm1989
Copy link
Author

@ktdreyer after looked at https://github.com/bji/libs3/blob/master/GNUmakefile, i think there is no need to put this PR to libs3 upstream. Bc GNUmakefile in ceph/libs3 was changed that 'make install' will do nothing.

@ktdreyer
Copy link
Member

You're building a standalone libs3 RPM, independent of ceph, right?
I think you want to use the libs3 from upstream in that case. As far as I know, the only reason Ceph forked libs3 was that distros didn't carry the package at the time, so we had to bundle it (cf. https://bugzilla.redhat.com/1164406)

@hjwsm1989
Copy link
Author

yes, u are right, i should use upstream libs3, does upstream libs3 can access ceph's radosgw?

@ktdreyer
Copy link
Member

does upstream libs3 can access ceph's radosgw?

Yes.

I've been working on packaging up libs3 for Fedora and EPEL. Here's a Copr repository with my work: https://copr.fedoraproject.org/coprs/ktdreyer/libs3/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants