Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preflight: support IBM repositories installation #199

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Conversation

guits
Copy link
Collaborator

@guits guits commented Feb 17, 2023

This makes the preflight playbook support IBM repositories.

This makes the preflight playbook support IBM repositories.

Signed-off-by: Guillaume Abrioux <[email protected]>
@guits guits added backport-quincy backport quincy backport-pacific backport pacific labels Feb 17, 2023
@andrewschoen
Copy link
Collaborator

This looks good to me, I like the usage of _ceph_repo. I think we just need to verify the correct values for the new ceph_ibm_* variables now.

Copy link
Collaborator

@andrewschoen andrewschoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just follow up with new default values for the ceph_ibm_* variables. I'm going to approve this.

@andrewschoen andrewschoen merged commit aeb0664 into devel Feb 17, 2023
guits added a commit that referenced this pull request Feb 17, 2023
preflight: support IBM repositories installation (backport #199)
andrewschoen added a commit that referenced this pull request Feb 17, 2023
preflight: support IBM repositories installation (backport #199)
@ktdreyer ktdreyer deleted the bluewashing branch February 20, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-pacific backport pacific backport-quincy backport quincy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants