Skip to content

Commit

Permalink
Merge pull request #194 from ceph/mergify/bp/pacific/pr-189
Browse files Browse the repository at this point in the history
whitelist_externals in tox.ini deprecated (backport #189)
  • Loading branch information
guits authored Feb 8, 2023
2 parents 58c9134 + 8ed26c4 commit c038e46
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions library/ceph_orch_host.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# limitations under the License.

from __future__ import absolute_import, division, print_function
from typing import List, Tuple
from typing import Optional, List, Tuple
__metaclass__ = type

from ansible.module_utils.basic import AnsibleModule # type: ignore
Expand Down Expand Up @@ -134,7 +134,7 @@ def update_host(module: "AnsibleModule",
action: str,
name: str,
address: str = '',
labels: List[str] = None) -> Tuple[int, List[str], str, str]:
labels: Optional[List[str]] = None) -> Tuple[int, List[str], str, str]:
cmd = build_base_cmd_orch(module)
cmd.extend(['host', action, name])
if action == 'add' and address:
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ setenv=
commands = py.test -vvv -n=auto {toxinidir}/tests/library/ {toxinidir}/tests/module_utils

[testenv:{el8,el9}-functional]
whitelist_externals =
allowlist_externals =
vagrant
bash
pip
Expand Down

0 comments on commit c038e46

Please sign in to comment.