Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus.py: add pool_name and image_name to subsystem_namespace_metadata #985

Closed
wants to merge 1 commit into from

Conversation

VallariAg
Copy link
Member

Add method _list_namespaces() to get rbd image/pool name of the namespace to expose them in metrics ceph_nvmeof_subsystem_namespace_metadata.

…tadata

Add method _list_namespaces() to get rbd image/pool name
to expose them in metrics ceph_nvmeof_subsystem_namespace_metadata.

Signed-off-by: Vallari Agrawal <[email protected]>
Copy link
Contributor

@pcuzner pcuzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed if the bdev metadata already contains the rbd pool and image names and the namespace_metadata has bdev_name?
Couldn't correlation be done prometheus side without having to iterate over more rpc calls?

@VallariAg
Copy link
Member Author

@pcuzner I have changed the prometheus query to make a correlation between ceph_nvmeof_bdev_metadata and ceph_nvmeof_subsystem_namespace_metadata (see output - ceph/ceph#60777).
We can close this PR now!

@VallariAg VallariAg closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants