Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdk: update to 23.01 #79

Merged
merged 3 commits into from
Mar 28, 2023
Merged

spdk: update to 23.01 #79

merged 3 commits into from
Mar 28, 2023

Conversation

idryomov
Copy link
Contributor

As discussed, I bumped SPDK to 23.01 in https://github.com/ceph/spdk. @sskaur please run this through your tests to pick up any SPDK RPC changes that might impact the gateway.

Signed-off-by: Ilya Dryomov <[email protected]>
Signed-off-by: Sandy Kaur <[email protected]>
@sskaur
Copy link
Contributor

sskaur commented Mar 16, 2023

@idryomov Looks good to me in general.

  1. I created fix spdk rpc import path #86 for a small fix

  2. I see a warning on bdev create:
    INFO:control.grpc:Received request to create bdev Ceph0 from rbd/mytestdevimage with block size 4096 WARNING:bdev_rbd_create should be used with specifying -c to have a cluster name after bdev_rbd_register_cluster.

  3. One other thing I noticed is that I cannot run a second instance of the SPDK target app on the same node without specifying a core mask. This will require a small change to the multi-gateway test in Initial multi-gateway support #29.

@idryomov idryomov marked this pull request as ready for review March 17, 2023 15:07
@idryomov
Copy link
Contributor Author

Thanks, I picked up your fix and removed the draft status here.

  1. One other thing I noticed is that I cannot run a second instance of the SPDK target app on the same node without specifying a core mask. This will require a small change to the multi-gateway test in Initial multi-gateway support #29.

Since #29 is not merged yet, I expected this to be addressed there.

@idryomov idryomov requested a review from trociny March 17, 2023 15:10
Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In README.md we have:

5. SPDK v21.04 is included in this repository. 

This needs updating or better just don't mention the version at all.

control/server.py Show resolved Hide resolved
@idryomov
Copy link
Contributor Author

This needs updating or better just don't mention the version at all.

Done

Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Thanks @idryomov !

@epuertat epuertat merged commit 66f34e4 into devel Mar 28, 2023
@epuertat epuertat deleted the wip-spdk-23.01 branch March 28, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants