Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4gws fixes #587

Merged
merged 4 commits into from
Apr 17, 2024
Merged

4gws fixes #587

merged 4 commits into from
Apr 17, 2024

Conversation

baum
Copy link
Collaborator

@baum baum commented Apr 16, 2024 •
edited
Loading

several fixes

  • tweak the 4gws test,to allow gateway IP change by using '0.0.0.0' as listener address
  • control/grpc.py
    • tweak listener matching logic, to disallow the creation of the same address/port listener on the same gateway only.
    • revert the OMAP lock from recycle
    • fix subsystem listeners state clean-up

Alexander Indenbaum added 4 commits April 16, 2024 14:10
control/grpc.py: fix matching listener logic
48aedee 
The function matching_listener_exists() previously prevented the creation of
identical address/port listeners on different gateways. While this safeguard
ensured a valid configuration, it also blocked scenarios where addresses
like 0.0.0.0:4420 and 127.0.0.r10:4420 could coexist on different gateways
simultaneously.

To address this, the logic has been adjusted to only disallow the creation of
the same address/port listener on the same gateway. This modification preserves
valid configurations while preventing conflicts within the same gateway context.

Signed-off-by: Alexander Indenbaum <[email protected]>
test/ha/4gws: allow gateway IP change by using 0.0.0.0 listeners
922e0e8 
Signed-off-by: Alexander Indenbaum <[email protected]>
control/grpc.py: revert the OMAP lock from recycle
6ddcb3e 
Signed-off-by: Alexander Indenbaum <[email protected]>
control/grpc.py: fix subsystem listeners state clean-up
e5d19de 
Signed-off-by: Alexander Indenbaum <[email protected]>
@baum baum merged commit e878d10 into ceph:devel Apr 17, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caroav caroav caroav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baum @caroav