server: fix missing group_id #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When mon client is disabled, the following stack trace appears: ``` nvmeof-1 | [08-Apr-2024 15:18:46] INFO server.py:244: Starting ceph nvmeof discovery service nvmeof-1 | [08-Apr-2024 15:18:46] ERROR server.py:107: GatewayServer exception occurred: nvmeof-1 | Traceback (most recent call last): nvmeof-1 | File "/src/control/__main__.py", line 43, in <module> nvmeof-1 | gateway.serve() nvmeof-1 | File "/src/control/server.py", line 177, in serve nvmeof-1 | self.gateway_rpc = GatewayService(self.config, gateway_state, self.rpc_lock, omap_lock, self.group_id, self.spdk_rpc_client, self.ceph_utils) nvmeof-1 | AttributeError: 'GatewayServer' object has no attribute 'group_id' nvmeof-1 | [08-Apr-2024 15:18:46] INFO server.py:391: Aborting (999a3cf6a97a) pid 37... nvmeof-1 | [08-Apr-2024 15:18:46] INFO state.py:354: nvmeof.state omap object already exists. nvmeof-1 | [08-Apr-2024 15:18:46] INFO discovery.py:322: log pages info from omap: nvmeof.state nvmeof-1 | [08-Apr-2024 15:18:47] INFO discovery.py:330: discovery addr: 0.0.0.0 port: 8009 nvmeof-1 | [08-Apr-2024 15:18:47] DEBUG discovery.py:1052: waiting for connection... nvmeof-1 | [08-Apr-2024 15:18:47] INFO server.py:423: Terminating discovery service... nvmeof-1 | [08-Apr-2024 15:18:47] DEBUG discovery.py:1072: received a ctrl+C interrupt. exiting... nvmeof-1 | [08-Apr-2024 15:18:47] INFO server.py:430: Discovery service terminated nvmeof-1 | [08-Apr-2024 15:18:47] INFO server.py:128: Exiting the gateway process. nvmeof-1 | [08-Apr-2024 15:18:47] INFO utils.py:391: Will compress log file /var/log/ceph/nvmeof-999a3cf6a97a/nvmeof-log to /var/log/ceph/nvmeof-999a3cf6a97a/nvmeof-log.gz nvmeof-1 | Traceback (most recent call last): nvmeof-1 | File "/usr/lib64/python3.9/runpy.py", line 197, in _run_module_as_main nvmeof-1 | return _run_code(code, main_globals, None, nvmeof-1 | File "/usr/lib64/python3.9/runpy.py", line 87, in _run_code nvmeof-1 | exec(code, run_globals) nvmeof-1 | File "/src/control/__main__.py", line 43, in <module> nvmeof-1 | gateway.serve() nvmeof-1 | File "/src/control/server.py", line 177, in serve nvmeof-1 | self.gateway_rpc = GatewayService(self.config, gateway_state, self.rpc_lock, omap_lock, self.group_id, self.spdk_rpc_client, self.ceph_utils) nvmeof-1 | AttributeError: 'GatewayServer' object has no attribute 'group_id' ``` Signed-off-by: Ernesto Puerta <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #558
When mon client is disabled, the following stack trace appears: