-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker,ci,make: add Ceph-Dashboard support and other improvements #362
docker,ci,make: add Ceph-Dashboard support and other improvements #362
Conversation
9c5c5f5
to
fa819e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🖖
@gbregman please review this PR as it removes part of the fixes you introduced for the missing CPU instruction. @baum I pulled off the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only I don't really know much about these files. One comment though, if you removed the SPDK_DISABLE_VPCLMULQDQ and SPDK_DISABLE_AVX512 vars, shouldn't you also remove them from .github/workflows/build-container.yml?
d645298
to
7bfac8b
Compare
@epuertat notice that on top of disabling the AVX512 and the MULQDQ instructions we also disable RDSEED. Only this id hardcoded in Dockerfile.spdk:
|
d713622
to
faa8fbd
Compare
dedcb06
to
0f0ca0c
Compare
f28d751
to
5fdbf48
Compare
5fdbf48
to
010a045
Compare
Signed-off-by: Ernesto Puerta <[email protected]>
010a045
to
15f8031
Compare
The v4 of these actions provide 90% speed-ups by compressing artifacts. Migration to this new action means zero cost. Additional core clean-up performed. Signed-off-by: Ernesto Puerta <[email protected]>
Signed-off-by: Ernesto Puerta <[email protected]>
ad9abee
to
7f89377
Compare
When a user pushes a change to a PR, if there was an ongoing CI run, this will cancel any previous runs. This will save some CO2. Signed-off-by: Ernesto Puerta <[email protected]>
5751b3b
to
b6d3040
Compare
This PR is to make it easier for developers to test Ceph-Dashboard when doing integration testing.
Fixes: #357
Fixes: #382
docker: add Ceph-Dashboard support
Include
ceph-mgr-dashboard
package and deps (grpcio).Create new ceph-devel service to mount local ceph repo inside the container (for dev purposes).
docker: add ceph-devel container
Also:
adding these to the history)
docker: add custom Ceph repo
https://3.chacra.ceph.com/r/ceph/ceph-nvmeof-mon/c1ced49d133c2bcd1fa9311a35688bf641b93c76/centos/9/flavors/default/)
clean_cache
to prune builder cache (required whenchanging the Ceph YUM Repo.
RPMs.
ceph-mon's ms_dispatch thread iterated through all available file
descriptors and tried to close them. By setting nofile to 1024, this
is heavily constrained. This behaviour is not exhibited with
Fedora's Moby-engine.
docker: support target-arch in SPDK
instructions.
ci: remove nvmeof-devel dependency
nvmeof-devel is not required for pytests, since they're mounted via
run
CLI command.make: fix alias issue
Alias was not properly working for
cephnvmf*
as it was erased from the shell history.docker: save SPDK target arch as label
SPDK/DPDK relies on pretty modern CPU instruction sets, which renders that incompatible with certain servers (Ivy Bridge and older). This new
SPDK_TARGET_ARCH
setting allows setting that. The new default (x86-64-v2
) could result in a less performant SPDK.ci: update upload-download artifact actions
The v4 of these actions provide 90% speed-ups by compressing artifacts.
Migration to this new action means zero cost.
Additional core clean-up performed.
ci: split ceph job and update checkout
There's no need for
ceph
to be built together with the rest of the nvmeof services. In fact this container could/should be pulled off to a separate repo/CI.ci: cancel CI run when another starts
When a user pushes a change to a PR, if there was an ongoing CI run,
this will cancel any previous runs. This will save some CO2.