Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 323 #326

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Issue 323 #326

merged 1 commit into from
Nov 19, 2023

Conversation

baum
Copy link
Collaborator

@baum baum commented Nov 19, 2023

Fixes: #323

Python error:
ceph-nvmeof-nvmeof-1 | File "/src/control/discovery.py", line 873, in _state_notify_update
ceph-nvmeof-nvmeof-1 | async_reply.dword0 = b'\x02\xf0\x70\x00'
ceph-nvmeof-nvmeof-1 | TypeError: an integer is required (got type bytes)

@baum baum requested a review from leonidc November 19, 2023 10:09
ceph-nvmeof-nvmeof-1  |   File "/src/control/discovery.py", line 873, in _state_notify_update
ceph-nvmeof-nvmeof-1  |     async_reply.dword0 =  b'\x02\xf0\x70\x00'
ceph-nvmeof-nvmeof-1  | TypeError: an integer is required (got type bytes)

Signed-off-by: Alexander Indenbaum <[email protected]>
@baum baum force-pushed the discovery_async_event_issue_323 branch from 5d1c3a3 to 5f8dba2 Compare November 19, 2023 13:59
@leonidc
Copy link
Collaborator

leonidc commented Nov 19, 2023

good job @baum

@baum baum merged commit 9c9cf95 into ceph:devel Nov 19, 2023
13 checks passed
@leonidc
Copy link
Collaborator

leonidc commented Nov 20, 2023

int_disc3.txt
tcpdump after fix . Async. event from the target can be seen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Host reconnects when Python discovery controller sends Async event
2 participants