Make sure OMAP's get_state() reads the entire file, even if it has more than 1024 keys #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbregman
force-pushed
the
devel
branch
3 times, most recently
from
be8ee94 to
4b4b97e
Compare
…re than 1024 keys Fixes ceph#263 Fixes ceph#266 Signed-off-by: Gil Bregman <[email protected]>
leonidc
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263
Fixes #266
The OMAP get_state() function only reads 1024 values from the OMAP file. When I had an OMAP file which was 3000 lines long I got an exception the the omap_version key wasn't found. Adding some debug messages I found out that the dictionary created from the values we read from the OMAP file was 1024 big and not 3000. So, even though we pass -1 to get_omap_vals() we only read 1024 lines from the file. We need to enclose this code in a loop and keep on reading from the OMAP until we read the entire file.