Add SPDK submodule.

[sdpeters]

Uses a fork of the SPDK github repo, so we're free to commit branches as

needed, as in this repo. The default branch in the SPDK fork repo will be wip-ceph-nvmeof.

Signed-off-by: Scott Peterson [email protected]

[idryomov]

Should this be targeted at devel instead of wip-skeleton?

[sdpeters]

Should this be targeted at devel instead of wip-skeleton?

That makes sense. We probably need a PR for this wip-skeleton branch then, because the devel branch seems to be empty so far.

[idryomov]

Do you want to own the spdk fork? We already have one in the ceph organization which we could start using: https://github.com/ceph/spdk. Going forward we would probably want to set up some CI on the ceph side, so it might be easier to have everything in one place.

[sdpeters]

Do you want to own the spdk fork? We already have one in the ceph organization which we could start using: https://github.com/ceph/spdk. Going forward we would probably want to set up some CI on the ceph side, so it might be easier to have everything in one place.

We can go either way. Who's the approver for PRs to https://github.com/ceph/spdk? Can that fork repo accommodate our branches without disrupting other work?

[idryomov]

We can go either way. Who's the approver for PRs to https://github.com/ceph/spdk? Can that fork repo accommodate our branches without disrupting other work?

I can approve and also add others as needed.

The fork hasn't been used in years so we won't disrupt anything.

[sdpeters]

We can go either way. Who's the approver for PRs to https://github.com/ceph/spdk? Can that fork repo accommodate our branches without disrupting other work?

I can approve and also add others as needed.

The fork hasn't been used in years so we won't disrupt anything.

OK, let me revise this patch to point to https://github.com/ceph/spdk. I'll submit a PR for https://github.com/ceph/spdk to add the wip-ceph-nvmeof branch.

[idryomov]

I'd call it ceph-nvmeof, without the wip prefix, to distinguish the submodule branch from other truly WIP branches.

[sdpeters]

I'd call it ceph-nvmeof, without the wip prefix, to distinguish the submodule branch from other truly WIP branches.

Will do

[idryomov]

I went ahead and created ceph-nvmeof branch in ceph/spdk.git so you have something to target your PR at. It is based on 20.07 as discussed.

[sdpeters]

This now refers to the ceph-nvmeof branch of the Ceph SPDK fork