Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When removing an non-existing namesapce host we shouldn't get an exception #964

Closed
gbregman opened this issue Nov 25, 2024 · 0 comments · Fixed by #997
Closed

When removing an non-existing namesapce host we shouldn't get an exception #964

gbregman opened this issue Nov 25, 2024 · 0 comments · Fixed by #997
Assignees
@gbregman

Comments

@gbregman
Copy link
Contributor

gbregman commented Nov 25, 2024 •
edited
Loading

When we try to remove a namespace host which doesn't exist, we get an exception about deleting a non-existing key. We need to catch such an exception and ignore it. Or, we need to verify that the host is there before trying to remove it.
@gbregman gbregman self-assigned this Nov 25, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in NVMe-oF Nov 25, 2024
@gbregman gbregman changed the title When removing an non-existing namesapce host we should get an exception When removing an non-existing namesapce host we shouldn't get an exception Nov 25, 2024
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Dec 22, 2024
@gbregman
Do not display an exception in case we delete a non-existing namespac…
a6908bd 
…e host.

Fixes ceph#964

Signed-off-by: Gil Bregman <[email protected]>
@gbregman gbregman mentioned this issue Dec 22, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NVMe-oF Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not display an exception in case we delete a non-existing namespace host gbregman/ceph-nvmeof
1 participant
@gbregman