Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus is started too early #919

Closed
gbregman opened this issue Oct 28, 2024 · 0 comments · Fixed by #922
Closed

Prometheus is started too early #919

gbregman opened this issue Oct 28, 2024 · 0 comments · Fixed by #922
Assignees
@gbregman

Comments

@gbregman
Copy link
Contributor

When we start the server we start running the Prometheus code before the server is done coming up. So, we get a couple of gRPC requests when the server is still initializing. We need to move the loading of Prometheus a few lines forward to the end of the server initialization.
@gbregman gbregman self-assigned this Oct 28, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in NVMe-oF Oct 28, 2024
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Oct 28, 2024
@gbregman
Move the Prometheus startup to the end of the server initialization.
c1ef511 
Fixes ceph#919

Signed-off-by: Gil Bregman <[email protected]>
@gbregman gbregman mentioned this issue Oct 28, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NVMe-oF Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move the Prometheus startup to the end of the server initialization gbregman/ceph-nvmeof
1 participant
@gbregman