Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to take OMAP lock on SPDK log commands #772

Closed
gbregman opened this issue Jul 29, 2024 · 0 comments · Fixed by #774
Closed

No need to take OMAP lock on SPDK log commands #772

gbregman opened this issue Jul 29, 2024 · 0 comments · Fixed by #774
Assignees
@gbregman

Comments

@gbregman
Copy link
Contributor

Right now we take the OMAP lock in get_spdk_nvmf_log_flags_and_level_safe(), set_spdk_nvmf_logs_safe() and disable_spdk_nvmf_logs_safe(). There is no need for that. These functions only deal with SPDK, they don't care about the state of the gateway resources. So, taking the RPC lock is enough.
@github-project-automation github-project-automation bot moved this to 🆕 New in NVMe-oF Jul 29, 2024
@gbregman gbregman self-assigned this Jul 29, 2024
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jul 30, 2024
@gbregman
Set SPDK log level on startup and do not lock OMAP for SPDK log comma…
49271b5 
…nds.

Fixes ceph#771
Fixes ceph#772

Signed-off-by: Gil Bregman <[email protected]>
@gbregman gbregman mentioned this issue Jul 30, 2024
Merged
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jul 30, 2024
@gbregman
Set SPDK log level on startup and do not lock OMAP for SPDK log comma…
f10ec40 
…nds.

Fixes ceph#771
Fixes ceph#772

Signed-off-by: Gil Bregman <[email protected]>
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jul 30, 2024
@gbregman
Set SPDK log level on startup and do not lock OMAP for SPDK log comma…
135cf3d 
…nds.

Fixes ceph#771
Fixes ceph#772

Signed-off-by: Gil Bregman <[email protected]>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NVMe-oF Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set SPDK log level on startup and do not lock OMAP for SPDK log commands gbregman/ceph-nvmeof
1 participant
@gbregman