Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to force ANA reporting to True also in gRPC #763

Closed
gbregman opened this issue Jul 23, 2024 · 1 comment · Fixed by #765
Closed

Need to force ANA reporting to True also in gRPC #763

gbregman opened this issue Jul 23, 2024 · 1 comment · Fixed by #765
Assignees

Comments

@gbregman
Copy link
Contributor

Long ago we changed the CLI to always use True for ANA reporting when creating a subsystem. But, a user bypassing the CLI and using gRPC directly can still pass False and create a subsystem without ANA. This might cause issues as we rely on the ANA information in different places. We need to force ANA reporting to True in gRPC as well.

@github-project-automation github-project-automation bot moved this to 🆕 New in NVMe-oF Jul 23, 2024
@gbregman gbregman self-assigned this Jul 23, 2024
@gbregman
Copy link
Contributor Author

I was wrong. We already check in gRPC and fail the create subsystem command in case "enable_ha" is false. But, we still have some leftovers from the times we could have false. So we need to clean them up.

gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jul 24, 2024
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jul 24, 2024
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jul 28, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NVMe-oF Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant