-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to force ANA reporting to True also in gRPC #763
Comments
I was wrong. We already check in gRPC and fail the create subsystem command in case "enable_ha" is false. But, we still have some leftovers from the times we could have false. So we need to clean them up. |
gbregman
added a commit
to gbregman/ceph-nvmeof
that referenced
this issue
Jul 24, 2024
Fixes ceph#763 Signed-off-by: Gil Bregman <[email protected]>
gbregman
added a commit
to gbregman/ceph-nvmeof
that referenced
this issue
Jul 24, 2024
Fixes ceph#763 Signed-off-by: Gil Bregman <[email protected]>
gbregman
added a commit
to gbregman/ceph-nvmeof
that referenced
this issue
Jul 28, 2024
Fixes ceph#763 Signed-off-by: Gil Bregman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Long ago we changed the CLI to always use True for ANA reporting when creating a subsystem. But, a user bypassing the CLI and using gRPC directly can still pass False and create a subsystem without ANA. This might cause issues as we rely on the ANA information in different places. We need to force ANA reporting to True in gRPC as well.
The text was updated successfully, but these errors were encountered: