Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_grpc.py test is broken #738

Closed
gbregman opened this issue Jun 27, 2024 · 0 comments · Fixed by #769
Closed

test_grpc.py test is broken #738

gbregman opened this issue Jun 27, 2024 · 0 comments · Fixed by #769
Assignees

Comments

@gbregman
Copy link
Contributor

The last change to test_grpc.py caused to stop testing what it was supposed to test. We want to execute CLI commands while update() is running and this is no longer the case. We need to move the sleep to its original position, after the loop of "subsystem list". To take care of the rare case we managed to execute a subsystem list before update had the chance to create a single subsystem we should wait until we see the first subsystem was created and only then go into the loop.

@gbregman gbregman self-assigned this Jun 27, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in NVMe-oF Jun 27, 2024
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jul 28, 2024
Fixes ceph#738

Signed-off-by: Gil Bregman <[email protected]>
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jul 28, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NVMe-oF Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant