Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the --host parameter of add/del host to --host-nqn #735

Closed
gbregman opened this issue Jun 26, 2024 · 0 comments · Fixed by #814
Closed

Change the --host parameter of add/del host to --host-nqn #735

gbregman opened this issue Jun 26, 2024 · 0 comments · Fixed by #814
Assignees
@gbregman

Comments

@gbregman
Copy link
Contributor

We got complaints that the --host parameter is confused with the --host-name parameter. To make things clearer we need to rename it to --host-nqn.
@github-project-automation github-project-automation bot moved this to 🆕 New in NVMe-oF Jun 26, 2024
@gbregman gbregman self-assigned this Jun 26, 2024
@gbregman gbregman changed the title Chnage the --host parameter of add/del host to --host-nqn Change the --host parameter of add/del host to --host-nqn Jun 26, 2024
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Aug 21, 2024
@gbregman
Change --host argument to --host-nqn in host add and del commands.
6eb43ae 
Fixes ceph#735

Signed-off-by: Gil Bregman <[email protected]>
@gbregman gbregman mentioned this issue Aug 21, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NVMe-oF Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change --host argument to --host-nqn in host add and del commands gbregman/ceph-nvmeof
1 participant
@gbregman