Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the namespace resize gRPC call to use size in MiBs #685

Closed
gbregman opened this issue May 28, 2024 · 0 comments · Fixed by #686
Closed

Change the namespace resize gRPC call to use size in MiBs #685

gbregman opened this issue May 28, 2024 · 0 comments · Fixed by #686
Assignees
@gbregman

Comments

@gbregman
Copy link
Contributor

In the past the namespace resize gRPC call accepted the new size in MiBs, as needed for SPDK. This was changed and we now pass the size in bytes. We should restore the original behavior as it is relied on in other components.
@github-project-automation github-project-automation bot moved this to 🆕 New in NVMe-oF May 28, 2024
@gbregman gbregman self-assigned this May 28, 2024
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue May 28, 2024
@gbregman
Use size in MiBs, not bytes, in namespace_resize gRRPC call
bb1ec85 
Fixes: ceph#685

Signed-off-by: Gil Bregman <[email protected]>
@gbregman gbregman mentioned this issue May 28, 2024
Merged
@gbregman gbregman changed the title Change the namespace resize gRPC call to use siz`e in MiBs Change the namespace resize gRPC call to use size in MiBs May 28, 2024
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue May 28, 2024
@gbregman
Use size in MiBs, not bytes, in namespace_resize gRRPC call
08a8b0e 
Fixes: ceph#685

Signed-off-by: Gil Bregman <[email protected]>
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue May 28, 2024
@gbregman
Use size in MiBs, not bytes, in namespace_resize gRRPC call
48c316b 
Fixes: ceph#685

Signed-off-by: Gil Bregman <[email protected]>
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue May 28, 2024
@gbregman
Use size in MiBs, not bytes, in namespace_resize gRRPC call
7c624c3 
Fixes: ceph#685

Signed-off-by: Gil Bregman <[email protected]>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NVMe-oF May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use size in MiBs, not bytes, in namespace_resize gRRPC call gbregman/ceph-nvmeof
1 participant
@gbregman