Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail gateway operations because of logging exceptions #589

Closed
gbregman opened this issue Apr 17, 2024 · 0 comments · Fixed by #590
Closed

Do not fail gateway operations because of logging exceptions #589

gbregman opened this issue Apr 17, 2024 · 0 comments · Fixed by #590
Assignees
@gbregman

Comments

@gbregman
Copy link
Contributor

We had some cases in which an SPDK call was flagged as failed even though it was successful, because we got an exception when trying to display the returned value in the log. We should make sure logging exceptions don't interfere with actual gateway operations.
@gbregman gbregman self-assigned this Apr 17, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in NVMe-oF Apr 17, 2024
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Apr 17, 2024
@gbregman
Ignore logging exceptions.
36930a7 
Fixes ceph#589

Signed-off-by: Gil Bregman <[email protected]>
@gbregman gbregman mentioned this issue Apr 17, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NVMe-oF Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore logging exceptions gbregman/ceph-nvmeof
1 participant
@gbregman