Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actual Ceph version to the log #293

Closed
gbregman opened this issue Oct 26, 2023 · 4 comments · Fixed by #295
Closed

Add actual Ceph version to the log #293

gbregman opened this issue Oct 26, 2023 · 4 comments · Fixed by #295
Assignees

Comments

@gbregman
Copy link
Contributor

Right now we display the version we used to build the vstart cluster. But, we don't know which Ceph is actually used with the gateway. We should add this information to the log to help us debug future issues.

@github-project-automation github-project-automation bot moved this to 🆕 New in NVMe-oF Oct 26, 2023
@gbregman gbregman self-assigned this Oct 26, 2023
@gbregman
Copy link
Contributor Author

@rahullepakshi , @caroav when the change is committed we'll get the following line in the log:

ceph-nvmeof-nvmeof-1  | INFO:control.state:Connected to Ceph with version "18.2.0 (5dd24139a1eada541a3bc16b6941c5dde975e26d) reef (stable)"

Is there anything you would like to change there?

gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Oct 26, 2023
@rahullepakshi
Copy link
Contributor

@rahullepakshi , @caroav when the change is committed we'll get the following line in the log:

ceph-nvmeof-nvmeof-1  | INFO:control.state:Connected to Ceph with version "18.2.0 (5dd24139a1eada541a3bc16b6941c5dde975e26d) reef (stable)"

Is there anything you would like to change there?

Above, 18.2.0 is still not giving exact ceph version. The more appropriate exact version would be from below example,
Upstream - ceph version 18.0.0-6774-g07872628 (0787262864508935dbafefdc86caa2c7957d776e) reef (dev)
or
ceph version 18.2.0-99.el9cp (3907976ec457510fcff7ac9039193741cf5c7d2b) reef (stable)

@gbregman
Copy link
Contributor Author

@rahullepakshi this text is what you get from Ceph when asking for a version. In your environment, with a different version of Ceph running you will get a slightly different text.

@gbregman
Copy link
Contributor Author

@rahullepakshi this is what I get in the Ceph container when asking for the version:

bash-5.1$ ceph version
ceph version 18.2.0 (5dd24139a1eada541a3bc16b6941c5dde975e26d) reef (stable)
bash-5.1$

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NVMe-oF Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants