Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_host and create_listener are allowed to apply multiple times without any message/errors #144

Closed
preethisn opened this issue May 29, 2023 · 1 comment · Fixed by #277
Closed

add_host and create_listener are allowed to apply multiple times without any message/errors #144

preethisn opened this issue May 29, 2023 · 1 comment · Fixed by #277
Assignees
@gbregman

Comments

@preethisn
Copy link

Add_host and Creation_listerner is allowed to be applied multiple times without any message to the user - We do not see any errors/message to the users when we apply the same add_host and create_listener commands multiple times.

Not sure why the API is allowing the ideomptancy for these commands. We expect some message when user tries to rerun the same commands multiple times.

[root@clara010 ceph-nvmeof]# python3 -m control.cli create_listener -n nqn.2016-06.io.spdk:nvme1 -s 5001
INFO:main:Created nqn.2016-06.io.spdk:nvme1 listener: True
[root@clara010 ceph-nvmeof]# python3 -m control.cli create_listener -n nqn.2016-06.io.spdk:nvme1 -s 5001
INFO:main:Created nqn.2016-06.io.spdk:nvme1 listener: True
[root@clara010 ceph-nvmeof]# python3 -m control.cli create_listener -n nqn.2016-06.io.spdk:nvme1 -s 5001

[root@clara010 ceph-nvmeof]# python3 -m control.cli add_host -n nqn.2016-06.io.spdk:nvme0 -t ''
INFO:main:Allowed open host access to nqn.2016-06.io.spdk:nvme0: True
[root@clara010 ceph-nvmeof]# python3 -m control.cli add_host -n nqn.2016-06.io.spdk:nvme0 -t ''
INFO:main:Allowed open host access to nqn.2016-06.io.spdk:nvme0: True
[root@clara010 ceph-nvmeof]#
@github-project-automation github-project-automation bot moved this to 🆕 New in NVMe-oF May 29, 2023
@gbregman gbregman self-assigned this Oct 1, 2023
@gbregman
Copy link
Contributor

@preethisn how about adding host "" to allow all hosts followed by add_host for specific hosts? Should we allow that? If we don't, it begs the question what to if we already have a few hosts added and then we add "". Should we remove the existing host entries?

gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Oct 22, 2023
@gbregman
Fail any attempt to create a duplicate listener or host.
93ffb59 
Also, minor changes to delete_bdev and ANA handling in create_listener.
Fixes ceph#144

Signed-off-by: Gil Bregman <[email protected]>
@gbregman gbregman mentioned this issue Oct 22, 2023
Merged
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Oct 22, 2023
@gbregman
Fail any attempt to create a duplicate listener or host.
c04cf91 
Also, minor changes to delete_bdev and ANA handling in create_listener.
Fixes ceph#144

Signed-off-by: Gil Bregman <[email protected]>
@gbregman gbregman changed the title Add_host and Creation_listerner are allowed to apply multiple times without any message/errors Add_host and Creation_listener are allowed to apply multiple times without any message/errors Oct 22, 2023
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Oct 22, 2023
@gbregman
Do not allow duplicate add_host and create_listener commands.
4033a51 
Fixes ceph#144

Signed-off-by: Gil Bregman <[email protected]>
@gbregman gbregman mentioned this issue Oct 22, 2023
Merged
@gbregman gbregman changed the title Add_host and Creation_listener are allowed to apply multiple times without any message/errors add_host and create_listener are allowed to apply multiple times without any message/errors Oct 22, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NVMe-oF Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not allow duplicate add_host and create_listener commands gbregman/ceph-nvmeof
2 participants
@preethisn @gbregman