Merge pull request #695 from gbregman/devel

Fix typo in log message and make sure address family is not empty
ceph · Jun 2, 2024 · 7867539 · 7867539
2 parents 35be592 + bb7dfc8
commit 7867539
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/control/grpc.py b/control/grpc.py
@@ -2054,10 +2054,14 @@ def list_connections_safe(self, request, context):
                             trtype = addr["trtype"].upper()
                         except Exception:
                             pass
+                        if not trtype:
+                            trtype = "TCP"
                         try:
                             adrfam = addr["adrfam"].lower()
                         except Exception:
                             pass
+                        if not adrfam:
+                            adrfam = "ipv4"
                         break
                     except Exception:
                         self.logger.exception(f"Got exception while parsing qpair: {qp}")
@@ -2069,7 +2073,7 @@ def list_connections_safe(self, request, context):
                 if hostnqn in host_nqns:
                     host_nqns.remove(hostnqn)
             except Exception:
-                self.logger.exception(f"{con=} parse error")
+                self.logger.exception(f"{conn=} parse error")
                 pass
 
         for nqn in host_nqns: