-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] rewrite RBD provisioning to use go-ceph instead of rbd command #729
Conversation
cf0ba84
to
7d7963f
Compare
@nixpanic thanks ! one question, instead of referring to your fork of ceph-go, cant we refer directly to go-ceph master branch? is it the case that, there are unmerged PRs in master against your fork ? |
7d7963f
to
cc3c927
Compare
There are currently changes under review in the go-ceph project that this PR takes advantage of. Hence the |
4d8d98e
to
5d2fe62
Compare
c7770e4
to
6722436
Compare
@nixpanic as we are tracking this for |
99484fa
to
49daaf6
Compare
A cleaned-up version, using the upstream available go-ceph API is available at #777. That PR only implements CreateVolume, this PR will get updated with more functionality while go-ceph gets extended. |
6461075
to
2178ec4
Compare
aee8423
to
2cee603
Compare
5d7c4e4
to
1ab621e
Compare
fe7f6bb
to
ca44f22
Compare
Make it easier to open an rbd.Image by hiding the rados.IOContext for functions that only need operate on an rbd.Image. Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Reduce the number of calls to the 'rbd' command, and replace it with the go-ceph API. While at it, modernize the calls to the functions to be more object oriented. Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
ca44f22
to
0c620eb
Compare
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
The majority of calls has been replaced by a go-ceph implementation. Follow the Use go-ceph for volume management operations project for an updated status. |
Describe what this PR does
This is a PR that should not be merged as is, but is used for Request For Comments.
There is a need to extend go-ceph with certain functions so that the current RBD provisioner can be rewritten to use the librbd.so library directly. This should increase performance.
Initial changes, and planned work, in no particular order:
createVolume()
deleteVolume()
, foreground only, not as a background taskrbdVolume
object that can have functionsThe changes in the branch used to create this PR depend on a work-in-progress version of go-ceph. Hopefully it will be possible to merge parts of this [RFC] PR when go-ceph functionality gets merged,
Related issues
See-also: #449