-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add VolumeGroupSnapshot examples for RBD #4901
Conversation
@@ -0,0 +1,12 @@ | |||
--- | |||
apiVersion: groupsnapshot.storage.k8s.io/v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nixpanic, I see example values are openshift specific.
Can you make it similar to cephfs groupsnapshotclass.yaml example file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, yes, it seems I missed some changes for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corrected this, please check again, thanks!
6fb9f3f
to
bbdfc14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bbdfc14
to
f23a322
Compare
Pull request has been modified.
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 395b062 |
By labelling the PersistentVolumeClaim with `group: test`, the label selector in the VolumeGroupSnapshot will create a snapshot of an RBD group containing the single volume (or more if there are other volumes in the same namespace with that label). Once the VolumeGroupSnapshot is created, each volume in the group will have a VolumeSnapshot that can be restored. Signed-off-by: Niels de Vos <[email protected]>
f23a322
to
fa9634f
Compare
/test ci/centos/upgrade-tests-cephfs |
/test ci/centos/upgrade-tests-rbd |
/test ci/centos/k8s-e2e-external-storage/1.30 |
/test ci/centos/mini-e2e-helm/k8s-1.30 |
/test ci/centos/mini-e2e/k8s-1.30 |
/test ci/centos/k8s-e2e-external-storage/1.31 |
/test ci/centos/mini-e2e-helm/k8s-1.31 |
/test ci/centos/mini-e2e/k8s-1.31 |
/test ci/centos/k8s-e2e-external-storage/1.29 |
/test ci/centos/mini-e2e-helm/k8s-1.29 |
/test ci/centos/mini-e2e/k8s-1.29 |
By labelling the PersistentVolumeClaim with
group: test
, the labelselector in the VolumeGroupSnapshot will create a snapshot of an RBD
group containing the single volume (or more if there are other volumes
in the same namespace with that label).
Once the VolumeGroupSnapshot is created, each volume in the group will
have a VolumeSnapshot that can be restored.
These files are also used by #4899 and eventually #4502, but the test is skipped until Ceph has a
new release with the required feature.