Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd: add image size in toSnapshot #4791

Merged
merged 1 commit into from
Aug 21, 2024
Merged

rbd: add image size in toSnapshot #4791

merged 1 commit into from
Aug 21, 2024

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Aug 21, 2024

we need to return the rbd image size as a snapshot size in CreateSnapshot Response.

fixes: #4788

@Madhu-1 Madhu-1 added the backport-to-release-v3.12 Label to backport from devel to release-v3.12 branch label Aug 21, 2024
@Madhu-1 Madhu-1 requested review from a team August 21, 2024 07:56
@mergify mergify bot added the component/rbd Issues related to RBD label Aug 21, 2024
@nixpanic
Copy link
Member

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 21, 2024

rebase

☑️ Nothing to do

  • any of:
    • #commits-behind>0 [📌 rebase requirement]
    • #commits>1 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position=-1 [📌 rebase requirement]

@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 21, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Pull request #4791 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Aug 21, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 21, 2024
@nixpanic
Copy link
Member

@Mergifyio unqueue

Lets merge #4790 now, and abort+restart CI jobs after a rebase.

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 21, 2024

unqueue

✅ The pull request has been removed from the queue default

@nixpanic
Copy link
Member

@Mergifyio rebase

@Madhu-1 @nixpanic
rbd: add image size in toSnapshot
a6a5794 
we need to return the rbd image size
as a snapshot size in CreateSnapshot
Response.

fixes: ceph#4788

Signed-off-by: Madhu Rajanna <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 21, 2024

rebase

✅ Branch has been successfully rebased

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 21, 2024
@nixpanic
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 21, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@nixpanic nixpanic added the ci/retry/e2e Label to retry e2e retesting on approved PR's label Aug 21, 2024
@nixpanic
Copy link
Member

there have been timeouts while request a VM for the CI jobs, added the ci/retry/e2e label.

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/upgrade-tests-rbd" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e-helm/k8s-1.31" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/k8s-e2e-external-storage/1.31" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/mini-e2e/k8s-1.29" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

@Madhu-1 "ci/centos/k8s-e2e-external-storage/1.29" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 21, 2024

requeue

☑️ This pull request is already queued

@mergify mergify bot merged commit 38fd27a into ceph:devel Aug 21, 2024
65 checks passed
@mergify mergify bot mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
backport-to-release-v3.12 Label to backport from devel to release-v3.12 branch ci/retry/e2e Label to retry e2e retesting on approved PR's component/rbd Issues related to RBD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

restoreSize is missing at snapshots after ceph-csi-rbd 12.1
4 participants
@Madhu-1 @nixpanic @ceph-csi-bot @iPraveenParihar