helm: don't specify default topology domainlabels in rbd chart #4776
Conversation
mergify
bot
added
the
component/deployment
|
Updated to resolve lint failure: |
|
Updated again; my fix for |
Remove the bad default, add commented-out standard labels as a suggestion. Fixes: #4775 Signed-off-by: Mark Glines <[email protected]>
|
Update: minimize diff, preserve the original indentation. |
|
@Mergifyio queue |
Madhu-1
added
the
backport-to-release-v3.12
🛑 The pull request has been removed from the queue
|
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
@Mergifyio requeue |
|
/test ci/centos/mini-e2e/k8s-1.29 |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Remove the bad default, add commented-out standard labels as a suggestion.
Describe what this PR does
This fixes a problem I noticed while digging into #4775.
It brings the default
topology.domainLabelsvalue in line with what the README.md claims (default={}), and in line with what the installer manifest does (leaves the command-line parameter commented out).Is there anything that requires special attention
I believe this change is beneficial enough to stand on its own. That said, these label definitions are 4 years old, and I don't know what's different between the 3.11.0 and 3.12.0 releases to cause #4775 to occur now.
I had to work around the problem with
helm --set topology.domainLabels=[], which worked for me. This PR updates the default to reflect that, and updates the comments to suggest the standard topology labels.There are two places in the helm chart which reference this value, both are guarded with:
So I think it doesn't need to be an explicitly empty array (
[]), leaving the whole thing commented out is fine.Related issues
Fixes: #4775
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)