Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs: Avoid hanging lock in volume mutex lock #4725

Merged
merged 1 commit into from
Jul 24, 2024
Merged

cephfs: Avoid hanging lock in volume mutex lock #4725

merged 1 commit into from
Jul 24, 2024

Conversation

Sunnatillo
Copy link
Contributor

@Sunnatillo Sunnatillo commented Jul 23, 2024 •
edited
Loading

Describe what this PR does

This PR allows to avoid hanging mutex lock scenario when fscrypt fails to unlock. Prevents uncessary delay

Related issues

Follow up improvement to #4697

Fixes: #4715

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes
    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@mergify mergify bot added the component/cephfs Issues related to CephFS label Jul 23, 2024
@Sunnatillo
Copy link
Contributor Author

/retest golangci-lint

@Sunnatillo Sunnatillo marked this pull request as ready for review July 23, 2024 13:08
nixpanic
nixpanic previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looks good to me

@nixpanic nixpanic requested a review from a team July 23, 2024 18:58
yati1998
yati1998 previously approved these changes Jul 24, 2024
View reviewed changes
@nixpanic
Copy link
Member

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 24, 2024

rebase

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
@Nordix needs to authorize modification on its head branch.

@Sunnatillo
cephfs: Avoid hanging lock in volume mutex lock
26d17d4 
This patch allows to avoid hanging mutex lock scenario when
fscrypt fails to unlock. Prevents uncessary delays

Signed-off-by: Sunnatillo <[email protected]>
@mergify mergify bot dismissed stale reviews from nixpanic and yati1998 July 24, 2024 07:58

Pull request has been modified.

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Jul 24, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jul 24, 2024
@nixpanic
Copy link
Member

/retest ci/centos/upgrade-tests

1 similar comment
@nixpanic
Copy link
Member

/retest ci/centos/upgrade-tests

@nixpanic
Copy link
Member

/retest ci/centos/upgrade-tests

Somehow these jobs keep pulling the old CentOS Stream 8 base images, eventhough the tag for the container-image was updated. I guess the images are cached somewhere, other jobs run fine, retrying again 🤞

@nixpanic
Copy link
Member

/retest ci/centos/upgrade-tests

@nixpanic
Copy link
Member

/retest ci/centos/upgrade-tests

This should work now. The ceph:v18 image is used from 2 different locations on the CI mirror. Both locations now have the updated image.

@nixpanic
Copy link
Member

/retest ci/centos/upgrade-tests-rbd

@mergify mergify bot merged commit d46b7d7 into ceph:devel Jul 24, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@yati1998 yati1998 yati1998 approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
component/cephfs Issues related to CephFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure ceph-lock is always released when staging encrypted cephfs volume
5 participants
@Sunnatillo @nixpanic @ceph-csi-bot @yati1998 @iPraveenParihar