Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update coding guideline to suggest to place local imports last #4721

Merged
merged 1 commit into from
Jul 23, 2024

doc: update coding guideline to suggest to place local imports last

54f99b6
Select commit
Loading
Failed to load commit list.
Merged

doc: update coding guideline to suggest to place local imports last #4721

doc: update coding guideline to suggest to place local imports last
54f99b6
Select commit
Loading
Failed to load commit list.
Mergify / Queue: Embarked in merge queue succeeded Jul 23, 2024 in 0s

The pull request embarked with devel (141da9a) will be merged soon

Required conditions for merge:

  • #approved-reviews-by>=2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • all of [📃 From pull request rule queue]:
    • -draft [📌 queue requirement]
    • any of [📌 queue -> configuration change requirements]:
      • -mergify-configuration-changed
      • check-success=Configuration changed
    • any of [🔀 queue conditions]:
      • all of [📌 queue conditions of queue default]:
        • #approved-reviews-by>=2 [🛡 GitHub branch protection]
        • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • any of:
    • all of:
      • base=devel
      • status-success=ci/centos/k8s-e2e-external-storage/1.27
      • status-success=ci/centos/k8s-e2e-external-storage/1.28
      • status-success=ci/centos/k8s-e2e-external-storage/1.29
      • status-success=ci/centos/k8s-e2e-external-storage/1.30
      • status-success=ci/centos/mini-e2e-helm/k8s-1.27
      • status-success=ci/centos/mini-e2e-helm/k8s-1.28
      • status-success=ci/centos/mini-e2e-helm/k8s-1.29
      • status-success=ci/centos/mini-e2e-helm/k8s-1.30
      • status-success=ci/centos/mini-e2e/k8s-1.27
      • status-success=ci/centos/mini-e2e/k8s-1.28
      • status-success=ci/centos/mini-e2e/k8s-1.29
      • status-success=ci/centos/mini-e2e/k8s-1.30
      • status-success=ci/centos/upgrade-tests-cephfs
      • status-success=ci/centos/upgrade-tests-rbd
      • status-success=codespell
      • status-success=go-test
      • status-success=golangci-lint
      • status-success=lint-extras
      • status-success=mod-check
      • status-success=multi-arch-build
    • all of:
      • base~=^(release-.+)$
      • status-success=ci/centos/k8s-e2e-external-storage/1.27
      • status-success=ci/centos/k8s-e2e-external-storage/1.28
      • status-success=ci/centos/k8s-e2e-external-storage/1.29
      • status-success=ci/centos/mini-e2e-helm/k8s-1.27
      • status-success=ci/centos/mini-e2e-helm/k8s-1.28
      • status-success=ci/centos/mini-e2e-helm/k8s-1.29
      • status-success=ci/centos/mini-e2e/k8s-1.27
      • status-success=ci/centos/mini-e2e/k8s-1.28
      • status-success=ci/centos/mini-e2e/k8s-1.29
      • status-success=ci/centos/upgrade-tests-cephfs
      • status-success=ci/centos/upgrade-tests-rbd
      • status-success=codespell
      • status-success=go-test
      • status-success=golangci-lint
      • status-success=lint-extras
      • status-success=mod-check
      • status-success=multi-arch-build
    • all of:
      • base=release-v3.10
      • status-success=ci/centos/k8s-e2e-external-storage/1.26
      • status-success=ci/centos/mini-e2e-helm/k8s-1.26
      • status-success=ci/centos/mini-e2e/k8s-1.26
      • status-success=ci/centos/k8s-e2e-external-storage/1.27
      • status-success=ci/centos/k8s-e2e-external-storage/1.28
      • status-success=ci/centos/mini-e2e-helm/k8s-1.27
      • status-success=ci/centos/mini-e2e-helm/k8s-1.28
      • status-success=ci/centos/mini-e2e/k8s-1.27
      • status-success=ci/centos/mini-e2e/k8s-1.28
      • status-success=ci/centos/upgrade-tests-cephfs
      • status-success=ci/centos/upgrade-tests-rbd
      • status-success=codespell
      • status-success=go-test
      • status-success=golangci-lint
      • status-success=lint-extras
      • status-success=mod-check
      • status-success=multi-arch-build
    • all of:
      • base=ci/centos
      • status-success=ci/centos/jjb-validate
      • status-success=ci/centos/job-validation

Check-runs and statuses of the embarked pull request #4721:

DCO — DCOdetails
any-branch-k8s-version details
branch-k8s-selection (devel, 1.27) details
branch-k8s-selection (devel, 1.28) details
branch-k8s-selection (devel, 1.29) details
branch-k8s-selection (devel, 1.30) details
branch-k8s-selection (release-v3.10, 1.26) details
branch-k8s-selection (release-v3.10, 1.27) details
branch-k8s-selection (release-v3.10, 1.28) details
branch-k8s-selection (release-v3.11, 1.27) details
branch-k8s-selection (release-v3.11, 1.28) details
branch-k8s-selection (release-v3.11, 1.29) details
ci/centos/k8s-e2e-external-storage/1.27 Build finished. details
ci/centos/k8s-e2e-external-storage/1.28 Build finished. details
ci/centos/k8s-e2e-external-storage/1.29 Build finished. details
ci/centos/k8s-e2e-external-storage/1.30 Build finished. details
ci/centos/mini-e2e-helm/k8s-1.27 Build finished. details
ci/centos/mini-e2e-helm/k8s-1.28 Build finished. details
ci/centos/mini-e2e-helm/k8s-1.29 Build finished. details
ci/centos/mini-e2e-helm/k8s-1.30 Build finished. details
ci/centos/mini-e2e/k8s-1.27 Build finished. details
ci/centos/mini-e2e/k8s-1.28 Build finished. details
ci/centos/mini-e2e/k8s-1.29 Build finished. details
ci/centos/mini-e2e/k8s-1.30 Build finished. details
ci/centos/upgrade-tests-cephfs Build finished. details
ci/centos/upgrade-tests-rbd Build finished. details
codespell details
commitlint details
dependency-review details
e2e-build-test details
go-test details
go-test-api details
golangci-lint details
lint-extras details
mod-check details
multi-arch-build details
remove-label details
View more details on Mergify