cleanup: do not pass EncodingVersion to GenerateVolID()
#4498
Conversation
|
|
|
@Mergifyio refresh |
✅ Pull request refreshed |
I don't know what Mergify means by this. Once other PRs are merged, this can be rebased and hopefully all is fine after that. |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
cleanup/GenerateVolID
branch
from
bb1c3bf
to
aad7d6b
Compare
nixpanic
force-pushed
the
cleanup/GenerateVolID
branch
3 times, most recently
from
484b390
to
9d8728c
Compare
|
Lets not skip the E2E as we have changed the code in go file. |
|
@Mergifyio rebase |
The only encoding version that exists is `1`. There is no need to have multiple constants for that version across different packages. Because there is only one version, `GenerateVolID()` does not really require it, and it can use a default version. If there is a need in the future to support an other encoding version, this can be revisited with a cleaner solution. Signed-off-by: Niels de Vos <[email protected]>
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
cleanup/GenerateVolID
branch
from
9d8728c
to
87188eb
Compare
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
The only encoding version that exists is
1. There is no need to have multiple constants for that version across different packages. Because there is only one version,GenerateVolID()does not really require it, and it can use a default version.If there is a need in the future to support an other encoding version, this can be revisited with a cleaner solution.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)