cleanup: simplify rbdGetDeviceList()
#4364
Conversation
|
/test ci/centos/mini-e2e/k8s-1.29 |
| GetRadosNamespace() string | ||
| GetDevice() string | ||
| } | ||
|
|
||
| // rbdDeviceInfo strongly typed JSON spec for rbd device list output (of type krbd). | ||
| type rbdDeviceInfo struct { |
There was a problem hiding this comment.
We no longer have to save ID ?
It's not used anywhere ?
There was a problem hiding this comment.
Indeed, it is not used anywhere for attaching/mounting.
|
@Mergifyio rebase |
The `rbdGetDeviceList()` function uses two very similar types for converting krbd and NBD device information from JSON. There is no need to use this distinction, and callers of `rbdGetDeviceList()` should not need to care about it either. By introducing a `deviceInfo` interface with Get-functions, the `rbdGetDeviceList()` function becomes a little simpler, with a clearly defined API for the returned list. Signed-off-by: Niels de Vos <[email protected]>
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
cleanup/rbd/deviceinfo
branch
from
3e74837
to
e780afb
Compare
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 3bf5c0e |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
The
rbdGetDeviceList()function uses two very similar types forconverting krbd and NBD device information from JSON. There is no need
to use this distinction, and callers of
rbdGetDeviceList()should notneed to care about it either.
By introducing a
deviceInfointerface with Get-functions, therbdGetDeviceList()function becomes a little simpler, with a clearlydefined API for the returned list.