Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: align seLinuxMount option w/ deploy folder #4346

Merged
merged 1 commit into from
Jan 3, 2024
Merged

helm: align seLinuxMount option w/ deploy folder #4346

merged 1 commit into from
Jan 3, 2024

Conversation

sebhoss
Copy link
Contributor

@sebhoss sebhoss commented Dec 22, 2023

Describe what this PR does

This aligns the CSIDriver configuration in the helm charts with the change introduced by c0201e4

Is there anything that requires special attention

This change is necessary for https://kubernetes.io/blog/2023/04/18/kubernetes-1-27-efficient-selinux-relabeling-beta/ to work while using the helm chart.

Related issues

Relates to #3855

Future concerns

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@mergify mergify bot added the component/deployment Helm chart, kubernetes templates and configuration Issues/PRs label Dec 22, 2023
Rakshith-R
Rakshith-R previously approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Rakshith-R Rakshith-R requested a review from a team December 26, 2023 08:54
riya-singhal31
riya-singhal31 previously approved these changes Dec 26, 2023
View reviewed changes
@riya-singhal31
Copy link
Contributor

riya-singhal31 commented Dec 28, 2023 •
edited
Loading

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 28, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Pull request #4346 has been dequeued due to failing checks or checks timeout.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@sebhoss
Copy link
Contributor Author

sebhoss commented Dec 28, 2023

@riya-singhal31 thanks for review & triggering the merge. The failed job said:

Unable to update: user sebhoss is unknown.

Please make sure sebhoss has logged in Mergify dashboard.

So I logged into Mergify & it should work now? Can you re-trigger this to try again?

@riya-singhal31
Copy link
Contributor

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 28, 2023

queue

🛑 The pull request has been removed from the queue default

Pull request #4346 has been dequeued due to failing checks or checks timeout.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@riya-singhal31
Copy link
Contributor

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 28, 2023

refresh

✅ Pull request refreshed

@riya-singhal31 riya-singhal31 added the ok-to-test Label to trigger E2E tests label Dec 28, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Dec 28, 2023
@mergify mergify bot dismissed stale reviews from riya-singhal31 and Rakshith-R December 29, 2023 05:31

Pull request has been modified.

@sebhoss
Copy link
Contributor Author

sebhoss commented Dec 29, 2023

Rebased on latest devel branch

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jan 2, 2024
@sebhoss
Copy link
Contributor Author

sebhoss commented Jan 3, 2024

The failing tests all got a timeout while talking to a container registry. I'm guessing that this is not related to the change in this PR. @Rakshith-R / @riya-singhal31: Can you retrigger these tests once more? 😰

@nixpanic
Copy link
Member

nixpanic commented Jan 3, 2024

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2024

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member

nixpanic commented Jan 3, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 017dddc

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Jan 3, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jan 3, 2024
@mergify mergify bot merged commit 017dddc into ceph:devel Jan 3, 2024
34 checks passed
@nixpanic nixpanic added the backport-to-release-v3.10 Label to backport from devel to release-v3.10 branch label Jan 4, 2024
@mergify mergify bot mentioned this pull request Jan 4, 2024
Merged
@Sebastian-RG Sebastian-RG mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riya-singhal31 riya-singhal31 riya-singhal31 approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees
No one assigned
Labels
backport-to-release-v3.10 Label to backport from devel to release-v3.10 branch component/deployment Helm chart, kubernetes templates and configuration Issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sebhoss @riya-singhal31 @ceph-csi-bot @Rakshith-R @nixpanic