Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make sure nfs-utils is installed #4243

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Nov 7, 2023

Ceph is minimizing their container-images, which can cause the
nfs-utils package to be dropped. As Ceph-CSI supports mounting NFS, it
needs the /sbin/mount.nfs executable, so install the package (or a
no-op if it is installed already).

See-also: https://rook-io.slack.com/archives/C46Q5UC05/p1699188662893109
Signed-off-by: Niels de Vos [email protected]

@mergify mergify bot added the component/build Issues and PRs related to compiling Ceph-CSI label Nov 7, 2023
@nixpanic nixpanic added the ci/skip/e2e skip running e2e CI jobs label Nov 7, 2023
@Rakshith-R
Copy link
Contributor

I think its better we run the entire ci just to be sure nothing breaks with this change.

@Rakshith-R Rakshith-R removed the ci/skip/e2e skip running e2e CI jobs label Nov 8, 2023
@riya-singhal31
Copy link
Contributor

@Mergifyio queue

Copy link
Contributor

mergify bot commented Nov 9, 2023

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d753eaa

Ceph is minimizing their container-images, which can cause the
`nfs-utils` package to be dropped. As Ceph-CSI supports mounting NFS, it
needs the `/sbin/mount.nfs` executable, so install the package (or a
no-op if it is installed already).

See-also: https://rook-io.slack.com/archives/C46Q5UC05/p1699188662893109
Signed-off-by: Niels de Vos <[email protected]>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Nov 9, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Nov 9, 2023
@mergify mergify bot merged commit d753eaa into ceph:devel Nov 9, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build Issues and PRs related to compiling Ceph-CSI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants