Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: allow mkfsOptions #4233

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

Sea-you
Copy link
Contributor

@Sea-you Sea-you commented Nov 6, 2023

Describe what this PR does

  • Allows configuration of mkfsOptions parameter in the ceph-csi-rbd chart.

Is there anything that requires special attention

Do you have any questions? False

Is the change backward compatible? True

Are there concerns around backward compatibility? False

Provide any external context for the change, if any.

For example:

  • It was present in the examples, but was missing from the chart.

Related issues

N/A

Future concerns

List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide
    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes

    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@Madhu-1 Madhu-1 requested a review from a team November 7, 2023 07:27
@riya-singhal31
Copy link
Contributor

@Mergifyio queue

Copy link
Contributor

mergify bot commented Nov 7, 2023

queue

🛑 The pull request has been removed from the queue default

Pull request #4233 has been dequeued due to failing checks or checks timeout.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
Copy link
Member

nixpanic commented Nov 9, 2023

@Mergifyio rebase

Signed-off-by: Domonkos Cinke <[email protected]>
Copy link
Contributor

mergify bot commented Nov 9, 2023

rebase

✅ Branch has been successfully rebased

@nixpanic nixpanic force-pushed the add/allow-mkfsOptions-from-chart branch from 18e334b to c128127 Compare November 9, 2023 12:05
@nixpanic
Copy link
Member

nixpanic commented Nov 9, 2023

@Mergifyio queue

Copy link
Contributor

mergify bot commented Nov 9, 2023

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Nov 9, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Nov 9, 2023
@nixpanic nixpanic added component/rbd Issues related to RBD component/deployment Helm chart, kubernetes templates and configuration Issues/PRs labels Nov 9, 2023
@nixpanic
Copy link
Member

nixpanic commented Nov 9, 2023

/retest ci/centos/mini-e2e-helm/k8s-1.27

@nixpanic
Copy link
Member

nixpanic commented Nov 9, 2023

/retest ci/centos/mini-e2e-helm/k8s-1.27

Unrelated(?) failure:

  Nov  9 12:43:03.487: INFO: Waiting for PV pvc-df79f100-e412-408e-af7a-b8e3c8d443cf to bind to PVC rbd-pvc
  Nov  9 12:43:03.487: INFO: Waiting up to timeout=10m0s for PersistentVolumeClaims [rbd-pvc] to have phase Bound
  Nov  9 12:43:03.489: INFO: PersistentVolumeClaim rbd-pvc found and phase=Bound (1.875492ms)
  Nov  9 12:43:03.489: INFO: Waiting up to 10m0s for PersistentVolume pvc-df79f100-e412-408e-af7a-b8e3c8d443cf to have phase Bound
  Nov  9 12:43:03.491: INFO: PersistentVolume pvc-df79f100-e412-408e-af7a-b8e3c8d443cf found and phase=Bound (1.794611ms)
  W1109 12:43:03.499504   91009 warnings.go:70] would violate PodSecurity "restricted:latest": allowPrivilegeEscalation != false (container "web-server" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "web-server" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "web-server" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "web-server" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
  Nov  9 12:43:03.499: INFO: Waiting up to csi-rbd-demo-pod to be in Running state
  Nov  9 12:53:03.500: INFO: failed to write data in the pod: context deadline exceeded
  Nov  9 12:53:03.500: INFO: >>> kubeConfig: /root/.kube/config
  �[38;5;9m[FAILED]�[0m in [It] - /go/src/github.com/ceph/ceph-csi/e2e/utils.go:1125 �[38;5;243m@ 11/09/23 12:53:03.507�[0m

logs

@nixpanic
Copy link
Member

nixpanic commented Nov 9, 2023

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Nov 9, 2023

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit d0fea3b into ceph:devel Nov 9, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/deployment Helm chart, kubernetes templates and configuration Issues/PRs component/rbd Issues related to RBD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants