Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: Allow templating of RBD striping parameters #4229

Merged
merged 1 commit into from
Nov 9, 2023
Merged

helm: Allow templating of RBD striping parameters #4229

merged 1 commit into from
Nov 9, 2023

Conversation

KingJ
Copy link
Contributor

@KingJ KingJ commented Nov 5, 2023

Describe what this PR does

PR #3132 added support for specifying stripeUnit, stripeCount and objectSize as storageClass parameters. However, these parameters were not added to storageClass templated by the Helm Chart at the time. A user who uses the Helm Chart to deploy ceph-csi-rbd could therefore only set these parameters if they managed the storageClass separately.

This PR therefore adds optional support for specifying stripeUnit, stripeCount and objectSize as parameters to the storageClass templated by the ceph-csi-rbd Helm Chart.

The descriptions for each option are taken from the "Available volume parameters" section of the RBD deployment docs, and extended slightly to reference the upstream Ceph documentation.

Is there anything that requires special attention

I've tried to keep the ordering of the new Helm Values similar to the ordering in the RBD deployment docs, however there are already a few inconsistencies. I'm happy to adjust the ordering if needed.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@mergify mergify bot added the component/deployment Helm chart, kubernetes templates and configuration Issues/PRs label Nov 5, 2023
@KingJ KingJ force-pushed the rbd-helm-stripe-object-options branch 2 times, most recently from 5ce9e11 to 61021a1 Compare November 5, 2023 17:46
@riya-singhal31
Copy link
Contributor

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Nov 6, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Nov 6, 2023
@KingJ
Copy link
Contributor Author

KingJ commented Nov 7, 2023

/retest ci/centos/k8s-e2e-external-storage/1.27

@KingJ
Copy link
Contributor Author

KingJ commented Nov 7, 2023

/retest ci/centos/k8s-e2e-external-storage/1.28

@KingJ
Copy link
Contributor Author

KingJ commented Nov 7, 2023

/retest ci/centos/mini-e2e-helm/k8s-1.26

@KingJ
Copy link
Contributor Author

KingJ commented Nov 7, 2023

/retest ci/centos/mini-e2e-helm/k8s-1.27

@KingJ
Copy link
Contributor Author

KingJ commented Nov 7, 2023

/retest ci/centos/mini-e2e-helm/k8s-1.28

@KingJ
Copy link
Contributor Author

KingJ commented Nov 7, 2023

/retest ci/centos/mini-e2e/k8s-1.27

@KingJ
Copy link
Contributor Author

KingJ commented Nov 7, 2023

/retest ci/centos/upgrade-tests-cephfs

@nixpanic
Copy link
Member

nixpanic commented Nov 8, 2023

@Mergifyio rebase

@KingJ @nixpanic
helm: Allow templating of RBD striping parameters
5e63f62 
Allow templating of stripeUnit, stripeCount and objectSize
storageClass parameters in ceph-csi-rbd chart

Signed-off-by: Kingsley Jarrett <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2023

rebase

✅ Branch has been successfully rebased

@nixpanic nixpanic force-pushed the rbd-helm-stripe-object-options branch from 61021a1 to 5e63f62 Compare November 8, 2023 21:40
@nixpanic
Copy link
Member

nixpanic commented Nov 8, 2023

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
Copy link
Member

nixpanic commented Nov 8, 2023

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2023

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@nixpanic
Copy link
Member

nixpanic commented Nov 9, 2023

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 9, 2023

rebase

✅ Nothing to do for rebase action

@nixpanic
Copy link
Member

nixpanic commented Nov 9, 2023

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 9, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Nov 9, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Nov 9, 2023
@nixpanic
Copy link
Member

nixpanic commented Nov 9, 2023

/retest ci/centos/mini-e2e/k8s-1.26

@nixpanic
Copy link
Member

nixpanic commented Nov 9, 2023

/retest ci/centos/mini-e2e/k8s-1.26

unrelated failure:

  [FAILED] failed to validate rbd images in pool replicapool trash: failed to list images in trash 2023-11-09T08:10:35.922+0000 7fbabb115700 -1 monclient: handle_auth_reply_more no authorizer?

logs

@nixpanic
Copy link
Member

nixpanic commented Nov 9, 2023

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 9, 2023

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 0a53b0d into ceph:devel Nov 9, 2023
35 checks passed
@KingJ KingJ deleted the rbd-helm-stripe-object-options branch November 9, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riya-singhal31 riya-singhal31 riya-singhal31 approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees
No one assigned
Labels
component/deployment Helm chart, kubernetes templates and configuration Issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KingJ @riya-singhal31 @ceph-csi-bot @nixpanic @Rakshith-R