Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove storageclass details for shallow volume #4124

Merged
merged 1 commit into from
Sep 14, 2023
Merged

doc: remove storageclass details for shallow volume #4124

merged 1 commit into from
Sep 14, 2023

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Sep 13, 2023

As shallow volumes are the default for ROX pvc from a snapshot, removing the details from the doc for better clarity.

@Madhu-1 Madhu-1 added component/docs Issues and PRs related to documentation ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Sep 13, 2023
@Madhu-1 Madhu-1 requested review from a team September 13, 2023 11:15
Rakshith-R
Rakshith-R requested changes Sep 14, 2023
View reviewed changes
docs/cephfs-snapshot-backed-volumes.md Outdated
* Define `spec.dataSource` for your desired source volume snapshot.
* Set `spec.accessModes` to `ReadOnlyMany`. This is the only access mode that
is supported by this feature.

Note:- We can also disable shallowVolume by setting `backingSnapshot: "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note:- We can also disable shallowVolume by setting `backingSnapshot: "true"
Note:- We can also disable shallowVolume by setting `backingSnapshot: "false"

@Madhu-1 Madhu-1 requested review from Rakshith-R and a team September 14, 2023 06:37
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Sep 14, 2023

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Pull request #4124 has been dequeued by an unqueue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Rakshith-R
Copy link
Contributor

@Mergifyio unqueue

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023

unqueue

✅ The pull request has been removed from the queue default

@Rakshith-R
Copy link
Contributor

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@Rakshith-R
Copy link
Contributor

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 32a58f4

@Madhu-1
doc: remove storageclass details for shallow volume
2e23ed4 
As shallow volumes are default for ROX pvc from
snapshot, removing the details from doc for better
clarity.

Signed-off-by: Madhu Rajanna <[email protected]>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Sep 14, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Sep 14, 2023
@Rakshith-R Rakshith-R mentioned this pull request Sep 14, 2023
Merged
@mergify mergify bot merged commit 32a58f4 into ceph:devel Sep 14, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riya-singhal31 riya-singhal31 riya-singhal31 approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Madhu-1 @Rakshith-R @ceph-csi-bot @riya-singhal31