ci: exclude branches from the testing matrix for ok-to-test comments
#4068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that `matrix.*` parameters can not be used in the if-statement for a job. Now using the `exclude:` parameter with a more dynamically constructed value for the branch. If the value for the branch is not part of the initial branch list, the value will not be excluded, so the jobs are expected to run. Signed-off-by: Niels de Vos <[email protected]>
nixpanic
added
ci/skip/e2e
|
/test ci/centos/k8s-e2e-external-storage |
|
/test ci/centos/mini-e2e-helm |
|
/test ci/centos/mini-e2e |
|
/test ci/centos/upgrade-tests |
Madhu-1
reviewed
Aug 22, 2023
| branch: devel | ||
| branch: > | ||
| ${{ "devel" == github.base_ref | ||
| && github.base_ref || "no-exclude" }} |
There was a problem hiding this comment.
@nixpanic can you point me to the reference to no-exclude? i tried to find one but didn't get any, how about below version
strategy:
matrix:
k8s: ["1.25", "1.26", "1.27", "1.28"]
branch:
- github.base_ref
exclude:
# the next Ceph-CSI version will not be tested with old Kubernetes
- k8s: "1.25"
branch: devel
# Ceph-CSI <= 3.9 was released before Kubernetes 1.28
- k8s: "1.28"
branch: release-v3.8
- k8s: "1.28"
branch: release-v3.9
if: >
(github.event.label.name == 'ok-to-test' &&
github.event.pull_request.merged != true )There was a problem hiding this comment.
no-exclude is just a placeholder. The branch: value is expanded to the name of the branch, or the non-existing branch no-exclude. If the branch: argument is a non-existing branch, the Kubernetes version will not be excluded (hence included and tested).
Madhu-1
approved these changes
Aug 22, 2023
riya-singhal31
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
matrix.*parameters can not be used in the if-statement for a job. Now using theexclude:parameter with a more dynamically constructed value for the branch. If the value for the branch is not part of the initial branch list, the value will not be excluded, so the jobs are expected to run.Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)