Add snapshot creation, deletion and restore from snapshot, Clone from PVC support for CephFS volumes. #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
14 tasks
|
As the ceph mgr interface currently provide the mechanism to do snapshot restore clone..etc, I am revisiting this PR to add support for the same in CSI layer. |
|
Unfortunately the upstream cephfs container image from above said release ( nautlius |
6 tasks
nixpanic
added
component/cephfs
humblec
force-pushed
the
cephfs-clone
branch
2 times, most recently
from
cf6711c
to
15a1cad
Compare
|
Marking this in |
humblec
changed the title
humblec
force-pushed
the
cephfs-clone
branch
6 times, most recently
from
3bfaec6
to
d7478ba
Compare
Compared to previous version of the error strings, this change depend on error strings like ENOENT, EEXIST, EINVAL..etc The format of the error strings change in different cluster versions and the error code return should not change. This also add extra error strings for snapshot and clone operation outputs Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
From provided CSI volume ID this populate volumeOptions and snapshot identifier after connecting to the snapJournal. Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
Also add functionality to generate snap from request and to get mon and clusterID from the request Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
It also add helper routines like parsetime,doSnapshot..etc Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
As we are populating the volume in other two test cases for clone and snapshot operation, we dont need a specific test case now. WriteDataInPod() function is also changed to take the pod spec and write some data to it Signed-off-by: Humble Chirammal <[email protected]>
|
Command Hey, I reacted but my real name is @Mergifyio |
nixpanic
approved these changes
Aug 7, 2020
|
LGTM! Not scoring as I have not looked at e2e in totality. |
Madhu-1
approved these changes
Aug 8, 2020
|
Thanks a lot @ShyamsundarR @Madhu-1 @nixpanic for taking effort to review such a big PR !! 👍 💯 |
This was referenced Aug 10, 2020
Nikhil-Ladha
pushed a commit
to Nikhil-Ladha/ceph-csi
that referenced
this pull request
Oct 9, 2024
Syncing latest changes from upstream devel for ceph-csi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Humble Chirammal [email protected]
Describe what this PR does
This PR will cover below features for CephFS:
Pending:
Additional Info:
*) Manual Testing of above functionalities are performed and its working as expected , see comment #394