rbd: return error if last sync time not present #3489
Conversation
Madhu-1
added
ci/skip/e2e
Madhu-1
force-pushed
the
fix-getreplication-info
branch
from
2e0afdf
to
c4ec529
Compare
go.mod
Outdated
| @@ -27,7 +27,7 @@ require ( | |||
| github.com/pkg/xattr v0.4.7 | |||
| github.com/prometheus/client_golang v1.12.2 | |||
| github.com/stretchr/testify v1.8.1 | |||
| golang.org/x/crypto v0.0.0-20220315160706-3147a52a75dd | |||
| golang.org/x/crypto v0.1.0 | |||
There was a problem hiding this comment.
this got updated as part of go get
|
@ShyamsundarR PTAL at last commit. This check was missing, and cephcsi was returning an empty response. |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
Madhu-1
force-pushed
the
fix-getreplication-info
branch
from
1a48237
to
7c1cbef
Compare
Thanks, I am only looking at overall structural correctness (hence not hitting the approved button). @yati1998 assuming you are taking a closer look? |
| if description == "" { | ||
| return nil, nil | ||
| return nil, fmt.Errorf("%w empty description", ErrLastSyncTimeNotFound) |
| } | ||
| splittedString := strings.SplitN(description, ",", 2) | ||
| if len(splittedString) == 1 { | ||
| return nil, nil | ||
| return nil, fmt.Errorf("%w no local snapshot timestamp", ErrLastSyncTimeNotFound) |
There was a problem hiding this comment.
same here, formatting of error messages matter
Madhu-1
force-pushed
the
fix-getreplication-info
branch
from
7c1cbef
to
642daa6
Compare
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
As per the csiaddon spec last sync time is required parameter in the GetVolumeReplicationInfo if we are failed to parse the description, return not found error message instead of nil which is empty response Signed-off-by: Madhu Rajanna <[email protected]>
csi-addons/spec#47 defines the error messages for the GetVolumeReplicationInfo RPC call. Signed-off-by: Madhu Rajanna <[email protected]>
Sometime the json unmarshal might get success and return empty time stamp. add a check to make sure the time is not zero always. Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
force-pushed
the
fix-getreplication-info
branch
from
642daa6
to
9f7624f
Compare
mergify
bot
dismissed
nixpanic’s stale review
Pull request has been modified.
|
@Mergifyio rebase |
☑️ Nothing to do
|
|
/test ci/centos/k8s-e2e-external-storage/1.23 |
|
/test ci/centos/k8s-e2e-external-storage/1.24 |
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.23 |
|
/test ci/centos/mini-e2e-helm/k8s-1.24 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/mini-e2e/k8s-1.23 |
|
/test ci/centos/mini-e2e/k8s-1.24 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
As per the csiaddon spec, last sync time is a required parameter in the GetVolumeReplicationInfo if we are failed to parse the description, we return an error message instead of nil which is an empty response.
Signed-off-by: Madhu Rajanna [email protected]
Note:- skipping E2E as we dont have CI for DR
Note:- Replacement for #3478 after discussion in csiaddons spec.