Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add github action to trigger E2E #3468

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Oct 25, 2022

based on the discussion on the slack channel. we are adding a github action
to trigger the CI jobs when a ok-to-test label is added on the PR.

This action is based on below github action https://github.com/peter-evans/create-or-update-comment

Sample Demo avaiable at Madhu-1/label-commentor-action-testing#4

Signed-off-by: Madhu Rajanna [email protected]

@Madhu-1 Madhu-1 added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Oct 25, 2022
@Madhu-1 Madhu-1 requested review from nixpanic and a team October 25, 2022 10:30
@mergify mergify bot added the component/testing Additional test cases or CI work label Oct 25, 2022
nixpanic
nixpanic previously approved these changes Oct 25, 2022
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please create the ok-to-test label and send a PR to not automatically start the jobs anymore.

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Oct 25, 2022
@nixpanic
Copy link
Member

Looks good to me. Please create the ok-to-test label and send a PR to not automatically start the jobs anymore.

Great, the label already exists! Thanks 👍

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Oct 25, 2022

@nixpanic Lets manually merge this PR to get CI job started?

@nixpanic
Copy link
Member

@nixpanic Lets manually merge this PR to get CI job started?

Wait until #3466 is merged?

Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this pull request Oct 25, 2022
Disable e2e tests by default in CI to
save resources. cephcsi maintainers or
contributors can add the ok-to-test label
to trigger the e2e tests.

depends on ceph#3468

Signed-off-by: Madhu Rajanna <[email protected]>
on:
pull_request_target:
types:
- labeled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the ci/* branch(es) be excluded from this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also wondering if this can be triggered after a rebase and the label is set...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can trigger only on required branches. for that we need to remove and re-add the label for now (we can see how that can be automated later?).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to run on devel and release branch for now

@mergify mergify bot dismissed nixpanic’s stale review October 25, 2022 11:39

Pull request has been modified.

@Madhu-1 Madhu-1 requested a review from nixpanic October 25, 2022 11:40
@Madhu-1 Madhu-1 added ok-to-test Label to trigger E2E tests and removed ok-to-test Label to trigger E2E tests labels Oct 25, 2022
Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this pull request Oct 25, 2022
Disable e2e tests by default in CI to
save resources. cephcsi maintainers or
contributors can add the ok-to-test label
to trigger the e2e tests.

depends on ceph#3468

Signed-off-by: Madhu Rajanna <[email protected]>
mergify bot pushed a commit that referenced this pull request Oct 26, 2022
Disable e2e tests by default in CI to
save resources. cephcsi maintainers or
contributors can add the ok-to-test label
to trigger the e2e tests.

depends on #3468

Signed-off-by: Madhu Rajanna <[email protected]>
based on the discussion on the slack
channel. we are adding a github action
to trigger the CI jobs when a ok-to-test
label is added on the PR.

This action is based on below github action
https://github.com/peter-evans/create-or-update-comment

Sample Demo avaiable at
https://github.com/Madhu-1/
\label-commentor-action-testing/pull/4

Signed-off-by: Madhu Rajanna <[email protected]>
with:
issue-number: ${{ github.event.pull_request.number }}
body: |
/test ci/centos/k8s-e2e-external-storage/1.22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/test ci/centos/k8s-e2e-external-storage/1.22
/test all

Can we instead just use all instead of multiple comments ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont want to trigger all (some experimental) tests we want to trigger individual tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Oct 26, 2022

/retest all

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Oct 26, 2022

/retest all

running retest all As we have skip CI label

@mergify mergify bot merged commit 659567c into ceph:devel Oct 26, 2022
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Oct 27, 2022

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2022

refresh

✅ Pull request refreshed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work ok-to-test Label to trigger E2E tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants