-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add github action to trigger E2E #3468
Conversation
8b8035c
to
a62832e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Please create the ok-to-test
label and send a PR to not automatically start the jobs anymore.
Great, the label already exists! Thanks 👍 |
@nixpanic Lets manually merge this PR to get CI job started? |
Disable e2e tests by default in CI to save resources. cephcsi maintainers or contributors can add the ok-to-test label to trigger the e2e tests. depends on ceph#3468 Signed-off-by: Madhu Rajanna <[email protected]>
on: | ||
pull_request_target: | ||
types: | ||
- labeled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can the ci/*
branch(es) be excluded from this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also wondering if this can be triggered after a rebase and the label is set...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we can trigger only on required branches. for that we need to remove and re-add the label for now (we can see how that can be automated later?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to run on devel and release branch for now
a62832e
to
05868d8
Compare
Pull request has been modified.
Disable e2e tests by default in CI to save resources. cephcsi maintainers or contributors can add the ok-to-test label to trigger the e2e tests. depends on ceph#3468 Signed-off-by: Madhu Rajanna <[email protected]>
Disable e2e tests by default in CI to save resources. cephcsi maintainers or contributors can add the ok-to-test label to trigger the e2e tests. depends on #3468 Signed-off-by: Madhu Rajanna <[email protected]>
based on the discussion on the slack channel. we are adding a github action to trigger the CI jobs when a ok-to-test label is added on the PR. This action is based on below github action https://github.com/peter-evans/create-or-update-comment Sample Demo avaiable at https://github.com/Madhu-1/ \label-commentor-action-testing/pull/4 Signed-off-by: Madhu Rajanna <[email protected]>
05868d8
to
c56e335
Compare
with: | ||
issue-number: ${{ github.event.pull_request.number }} | ||
body: | | ||
/test ci/centos/k8s-e2e-external-storage/1.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test ci/centos/k8s-e2e-external-storage/1.22 | |
/test all |
Can we instead just use all
instead of multiple comments ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dont want to trigger all (some experimental) tests we want to trigger individual tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
/retest all |
running |
@Mergifyio refresh |
✅ Pull request refreshed |
based on the discussion on the slack channel. we are adding a github action
to trigger the CI jobs when a
ok-to-test
label is added on the PR.This action is based on below github action https://github.com/peter-evans/create-or-update-comment
Sample Demo avaiable at Madhu-1/label-commentor-action-testing#4
Signed-off-by: Madhu Rajanna [email protected]