Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd: Use rados namespace when getting clone depth #3232

Merged
merged 1 commit into from
Jul 7, 2022
Merged

rbd: Use rados namespace when getting clone depth #3232

merged 1 commit into from
Jul 7, 2022

Conversation

BenoitKnecht
Copy link
Contributor

Description

When the Ceph user is restricted to a specific namespace in the pool, it is
crucial that evey interaction with the cluster is done within that namespace.
This wasn't the case in getCloneDepth().

This issue was causing snapshot creation to fail with

Failed to check and update snapshot content: failed to take snapshot of the volume X: "rpc error: code = Internal desc = rbd: ret=-1, Operation not permitted"

Related issues

Fixes: #3231

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)
  • /retest all: run this in case the CentOS CI failed to start/report any test
    progress or results

@mergify mergify bot added the component/rbd Issues related to RBD label Jul 6, 2022
Rakshith-R
Rakshith-R approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, Thanks for the contribution !

@Rakshith-R Rakshith-R requested a review from a team July 7, 2022 07:05
@BenoitKnecht @mergify
rbd: Use rados namespace when getting clone depth
ce36226 
When the Ceph user is restricted to a specific namespace in the pool, it is
crucial that evey interaction with the cluster is done within that namespace.
This wasn't the case in `getCloneDepth()`.

This issue was causing snapshot creation to fail with

> Failed to check and update snapshot content: failed to take snapshot of the
> volume X: "rpc error: code = Internal desc = rbd: ret=-1, Operation not
> permitted"

Signed-off-by: Benoît Knecht <[email protected]>
@nixpanic nixpanic added the ci/retry/e2e Label to retry e2e retesting on approved PR's label Jul 7, 2022
@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.21

@ceph-csi-bot
Copy link
Collaborator

@BenoitKnecht "ci/centos/mini-e2e/k8s-1.21" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/k8s-e2e-external-storage/1.23

@ceph-csi-bot
Copy link
Collaborator

@BenoitKnecht "ci/centos/k8s-e2e-external-storage/1.23" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/k8s-e2e-external-storage/1.21

@ceph-csi-bot
Copy link
Collaborator

@BenoitKnecht "ci/centos/k8s-e2e-external-storage/1.21" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.23

@ceph-csi-bot
Copy link
Collaborator

@BenoitKnecht "ci/centos/mini-e2e-helm/k8s-1.23" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.21

@ceph-csi-bot
Copy link
Collaborator

@BenoitKnecht "ci/centos/mini-e2e-helm/k8s-1.21" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.22

@ceph-csi-bot
Copy link
Collaborator

@BenoitKnecht "ci/centos/mini-e2e-helm/k8s-1.22" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

requeue

☑️ This pull request is already queued

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e/k8s-1.21

@ceph-csi-bot
Copy link
Collaborator

@BenoitKnecht "ci/centos/mini-e2e/k8s-1.21" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

requeue

☑️ This pull request is already queued

@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.22

@ceph-csi-bot
Copy link
Collaborator

@BenoitKnecht "ci/centos/mini-e2e-helm/k8s-1.22" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

requeue

☑️ This pull request is already queued

@mergify mergify bot merged commit 507844c into ceph:devel Jul 7, 2022
@BenoitKnecht BenoitKnecht deleted the fix-snapshot-namespace branch July 8, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
ci/retry/e2e Label to retry e2e retesting on approved PR's component/rbd Issues related to RBD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rbd: Snapshot creation fails when Ceph user is restricted to a rados namespace
4 participants
@BenoitKnecht @ceph-csi-bot @nixpanic @Rakshith-R